Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default branch name should be "main" #32

Open
alex-ikse opened this issue Sep 22, 2022 · 2 comments
Open

default branch name should be "main" #32

alex-ikse opened this issue Sep 22, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
Improve labs

Comments

@alex-ikse
Copy link

sfeir-school-github-action-dev/steps/50-lifecycle-lab1-marketplace-solution/.github/workflows/release-workflow.yml

Line 12 in f3a40a3

if: github.ref == 'refs/heads/master'

@alex-ikse
Copy link
Author

idem for:

sfeir-school-github-action-dev/steps/50-lifecycle-lab2-dist/.github/workflows/release-workflow.yml

Line 14 in f3a40a3

if: github.ref == 'refs/heads/master'

sfeir-school-github-action-dev/steps/50-lifecycle-lab2-dist-solution/.github/workflows/release-workflow.yml

Line 16 in f3a40a3

if: github.ref == 'refs/heads/master'

@rlespinasse
Copy link
Member

Semantic release don't support main with default configuration yet.

semantic-release/semantic-release#2214 (comment)

To ease the associated lab, we can find a way to add main to the configuration without adding complexity the lab itself.

@rlespinasse rlespinasse added the enhancement New feature or request label Sep 22, 2022
@rlespinasse rlespinasse mentioned this issue Sep 22, 2022
Open
@rlespinasse rlespinasse added this to the Improve labs milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Improve labs
Development

No branches or pull requests
2 participants
@rlespinasse @alex-ikse