Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be easier to deal with errors if the error kind is made pub #583

Open
asahaf opened this issue Mar 14, 2020 · 5 comments
Open

It would be easier to deal with errors if the error kind is made pub #583

asahaf opened this issue Mar 14, 2020 · 5 comments

Comments

@asahaf
Copy link

asahaf commented Mar 14, 2020

Hi,

Some errors, like closed, column, and row_count, don't have a cause (None). for these errors, there is no way to know the actual underlayer error as the error kind is not exposed.
It would be easier if the error kind is made public.

Thanks,

@hhirtz
Copy link

hhirtz commented Mar 31, 2020

Duplicate of #571?

@hn-sl
Copy link

hn-sl commented Feb 9, 2021

Any update? This is absolutely necessary to handle error properly when cause is None.

@hhirtz
Copy link

hhirtz commented Feb 9, 2021

I mean if it's a matter of removing 4 chars from a file anyone concerned could send a patch.

@palfrey
Copy link
Contributor

palfrey commented Dec 29, 2022

@couchand
Copy link

couchand commented Mar 3, 2023

I've run into this from the same place @palfrey seems to: trying to figure out if it's worth retrying the request (c.f. djc/bb8#141). @sfackler would you be open to a PR simliar to #739 that exposes a method with this information?

One possible difficulty is identifying which kinds of errors should be included. @palfrey's workaround looks for Kind::ConfigParse errors, and @levi-nz's issue implies Kind::Authentication should be included. In a quick review of the enum variants, none stand out to me, but perhaps there are others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants