Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Openssl 3 deprecated functions #1763

Merged
merged 1 commit into from Dec 20, 2022
Merged

Mark Openssl 3 deprecated functions #1763

merged 1 commit into from Dec 20, 2022

Conversation

CfirTsabari
Copy link
Contributor

Solve #1745
mark this functions as OPENSSL_NO_DEPRECATED_3_0

openssl::aes::aes_ige
openssl::bn::BigNumRef::pseudo_rand_range
openssl::bn::BigNumRef::pseudo_rand
openssl::bn::BigNumRef::is_prime
openssl::bn::BigNumRef::is_prime_fasttest

@CfirTsabari CfirTsabari force-pushed the cfirtsabari/deperecated-functions-1745 branch from 68bbdfe to 56af744 Compare December 20, 2022 13:42
sfackler
sfackler reviewed Dec 20, 2022
View reviewed changes
openssl-sys/src/handwritten/aes.rs Outdated
@@ -37,3 +28,17 @@ extern "C" {
inlen: c_uint,
) -> c_int;
}
cfg_if! {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need a cfg_if, it can just be left where it was previously and tagged with the cfg directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it .

@CfirTsabari CfirTsabari force-pushed the cfirtsabari/deperecated-functions-1745 branch 2 times, most recently from d1ab553 to f1434b4 Compare December 20, 2022 13:58
sfackler
sfackler reviewed Dec 20, 2022
View reviewed changes
openssl-sys/src/handwritten/bn.rs Outdated
cb: *mut BN_GENCB,
) -> c_int;
}
cfg_if! {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it .

@CfirTsabari CfirTsabari force-pushed the cfirtsabari/deperecated-functions-1745 branch from f1434b4 to 27edce9 Compare December 20, 2022 14:09
@sfackler sfackler merged commit deac6b7 into sfackler:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfackler sfackler sfackler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CfirTsabari @sfackler