Add support for X509_load_cert_file #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderjordanbaker
force-pushed
the
X509LoadCertFile
branch
2 times, most recently
from
4f964e6
to
6b43fae
Compare
sfackler
reviewed
Dec 1, 2022
openssl/src/x509/store.rs
Outdated
| /// Marker type corresponding to the [`X509_LOOKUP_file`] lookup method. | ||
| /// | ||
| /// [`X509_LOOKUP_file`]: https://www.openssl.org/docs/man1.1.1/man3/X509_LOOKUP_file.html | ||
| pub struct ASN1; |
There was a problem hiding this comment.
Why is this called ASN1 and not e.g. File?
There was a problem hiding this comment.
Thank you for pointing that out, that was a reference that I didn't replace with the appropriate name when creating the PR. I've updated the name to be File to match the HashDir struct above
alexanderjordanbaker
force-pushed
the
X509LoadCertFile
branch
from
6b43fae
to
7e78751
Compare
sfackler
reviewed
Dec 3, 2022
openssl/src/x509/store.rs
Outdated
| impl X509LookupRef<File> { | ||
| #[corresponds(X509_load_cert_file)] | ||
| /// Specifies a file from which certificates will be loaded | ||
| pub fn load_cert_file(&mut self, file: &str, file_type: SslFiletype) -> Result<(), ErrorStack> { |
There was a problem hiding this comment.
The type of file should be impl AsRef<Path> like here: https://docs.rs/openssl/latest/src/openssl/ssl/mod.rs.html#902-912
|
LGTM other than the method signature! |
alexanderjordanbaker
force-pushed
the
X509LoadCertFile
branch
from
7e78751
to
5ae938e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.