Add openssl::dsa::DsaSig #1709
Merged
Add openssl::dsa::DsaSig #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
add-dsa-sig
branch
8 times, most recently
from
b2e829e
to
dd68b90
Compare
|
Sorry for the flood of force-pushes but the CI pipeline here is really comprehensive and I can't (or don't know how) to test that locally 😅 Thank you for your time 🙇 |
sfackler
reviewed
Oct 27, 2022
|
Looks good to me other than the one function name! |
wiktor-k
force-pushed
the
add-dsa-sig
branch
2 times, most recently
from
d2a8b51
to
1d4a438
Compare
|
Function name adjusted. |
Skepfyr
reviewed
Nov 1, 2022
Adds safe interface for parsing and constructing DSA signatures and their components: `r` and `s`.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds safe interface for parsing and constructing DSA signatures and their components:
rands.This mirrors the interface offered by
EcdsaSigwith one omission: there is nosignmethod onDsaSig(as inEcdsaSig) sinceDSA_do_signseems to be deprecated.