Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis support #8

Open
andyw8 opened this issue May 2, 2022 · 4 comments · May be fixed by #13
Open

Add Redis support #8

andyw8 opened this issue May 2, 2022 · 4 comments · May be fixed by #13

Comments

@andyw8
Copy link
Collaborator

andyw8 commented May 2, 2022

No description provided.

@andyw8
Copy link
Collaborator Author

andyw8 commented Nov 25, 2022

@andyw8 andyw8 linked a pull request Nov 25, 2022 that will close this issue
@schonert
Copy link

Hey Andy - anything we can do to make this happen? :)

@andyw8
Copy link
Collaborator Author

andyw8 commented Mar 10, 2023

👋 I've just added some basic support and it's working for the example app:
https://github.com/andyw8/setup-rails-example-app/blob/main/spec/redis_spec.rb

Can you try point your config to use the main branch and see if works for you? i.e.

uses: setup-rails/setup-rails/.github/workflows/verify.yml@main

The downside is that this will add a few seconds to everyone's build even if they're not using Redis – I'm not yet sure how best to handle that.

@schonert
Copy link

Hey again! I'll most likely be migrating our current moonshine setup over, to something like this, within the month.

So, sadly, I can't test it yet. Setting up a redis outside is no biggie - so if passing the connection through is possible there there will be no need to choke everyone's pipelines for a nice-to-have 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants