De-duplicate phf

[Loirooriol]

servo/stylo@d0095a5 updated Stylo's phf to 0.11

So now we have some duplication

• duplicate versions for package phf
  • The following packages depend on version 0.10.1 from 'crates.io':
    • markup5ever 0.11.0
    • script 0.0.1
  • The following packages depend on version 0.11.2 from 'crates.io':
    • cssparser 0.31.2
    • selectors 0.24.0
• duplicate versions for package phf_codegen
  • The following packages depend on version 0.10.0 from 'crates.io':
    • markup5ever 0.11.0
    • script 0.0.1
  • The following packages depend on version 0.11.2 from 'crates.io':
    • selectors 0.24.0
• duplicate versions for package phf_generator
  • The following packages depend on version 0.10.0 from 'crates.io':
    • phf_codegen 0.10.0
    • string_cache_codegen 0.5.2
  • The following packages depend on version 0.11.2 from 'crates.io':
    • phf_codegen 0.11.2
    • phf_macros 0.11.2
• duplicate versions for package phf_shared
  • The following packages depend on version 0.10.0 from 'crates.io':
    • phf 0.10.1
    • phf_codegen 0.10.0
    • phf_generator 0.10.0
    • script 0.0.1
    • string_cache 0.8.7
    • string_cache_codegen 0.5.2
  • The following packages depend on version 0.11.2 from 'crates.io':
    • phf 0.11.2
    • phf_codegen 0.11.2
    • phf_generator 0.11.2
    • phf_macros 0.11.2

To avoid the duplication we should do something like:

• Update script to use phf 0.11
  Update phf_codegen and phf_shared to 0.11 #31537
• markup5ever was already updated to 0.11 (servo/html5ever@b9f858c), but this commit is in no released version, so we need a new release
  Release version 0.12.1 of markup5ever html5ever#537
• Update string_cache to phf 0.11
  Update phf to 0.11 string-cache#281
• Release a new version of string_cache
• Update Stylo to use the new html5ever/markup5ever/xml5ever
  Switch to markup5ever's version of Atom and upgrade xml5ever stylo#34
• Update Servo to use the new html5ever/markup5ever/xml5ever
  Bump Stylo to servo/stylo#34 and upgrade html5ever and xml5ever #32145
• Update servo and style to use the new string_cache

[Loirooriol]

Update script to use phf 0.11

This part could be a good 1st patch for people who want to get started on this project.

Basically, update

servo/components/script/Cargo.toml

Lines 25 to 26 in 3a3e76a

	phf_codegen = "0.10"
	phf_shared = "0.10"

to version 0.11. Then build so that Cargo.lock gets updated and to ensure that everything is fine with the update.

[servo-highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in Zulip.

If you intend to work on this issue, then add @servo-highfive: assign me to your comment, and I'll assign this to you. 😄

[MunishMummadi]

@servo-highfive : assign me. Can i work on this project

[servo-highfive]

Hey @MunishMummadi! Thanks for your interest in working on this issue. It's now assigned to you!

[Arnav2824]

@Loirooriol Has this issue been already closed? If no, then I would like to work on it

[mrobinson]

The next step is probably to update string_cache to use phf 0.11. The repository is here: http://github.com/servo/string_cache.

[Arnav2824]

Hey @mrobinson , I am unable to find the repository with the link that you have shared with me. It is giving me error 404 every time I click on it. Can you please provide me with another link?

[mrobinson]

@Arnav2824 Apologies, I mistyped the name of the repository. It is: https://github.com/servo/string-cache

[mrobinson]

@Arnav2824 Apologies, I mistyped the name of the repository. It is: https://github.com/servo/string-cache

It looks like there is already a PR up for this issue at servo/string-cache#281.

[Arnav2824]

So is there anything that I can do for this issue or has it been already completed?

[Loirooriol]

There are still parts that need to be done (I have updated the top comment), but they involve publishing new versions of the dependencies. Even though updating the dependencies of the dependencies and increasing the version number of the dependencies may not be that hard, I think they can only be published on crates.io by the Servo org, so probably not appropriate for Outreachy applicants.

[djc]

I've started looking at the markup5ever/xml5ever/html5ever bump here: servo/html5ever#516.

Does anyone here have context on how phf crates leak into the public API of these crates?