Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing for Content-Length with multiple values #28296

Open
ghostd opened this issue Mar 16, 2021 · 1 comment
Open

Tests failing for Content-Length with multiple values #28296

ghostd opened this issue Mar 16, 2021 · 1 comment

Comments

@ghostd
Copy link
Contributor

ghostd commented Mar 16, 2021

The fetch specification has been updated to handle multiple values for the Content-Length header.

The tests are here

The hyper client fails while parsing the headers, i opened an issue to track the problem.

@ghostd
Copy link
Contributor Author

ghostd commented Mar 28, 2021

The issue is fixed with the release 0.4.15.

I tried to upgrade hyper in servo (from 0.12 to 0.14), but i'm stuck with a serde issue:

error[E0277]: the trait bound `for<'de> De<http::HeaderMap>: Deserialize<'de>` is not satisfied
   --> components/net_traits/lib.rs:668:18
    |
668 |     pub headers: Option<Serde<HeaderMap>>,
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ the trait `for<'de> Deserialize<'de>` is not implemented for `De<http::HeaderMap>`
    | 
   ::: /home/xxxx/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper_serde-0.11.1/src/lib.rs:182:27
    |
182 |     where for<'de> De<T>: Deserialize<'de>,
    |                           ---------------- required by this bound in `Serde`
    |
    = help: the following implementations were found:
              <De<(http::status::StatusCode, std::string::String)> as Deserialize<'de>>
              <De<ContentType> as Deserialize<'de>>
              <De<Mime> as Deserialize<'de>>
              <De<Tm> as Deserialize<'de>>
            and 4 others

I guess we need to update and finish this hyper_serde PR, but i'm not yet very comfortable with this king of serialization issues :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants