Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IDNA dependency non-optional #790

Merged
merged 1 commit into from Sep 7, 2022
Merged

Conversation

crowlKats
Copy link
Contributor

No description provided.

@valenting
Copy link
Collaborator

This commit reverts #728 that made the IDNA dependency optional to reduce wasm file size.
However, users of the url crate, that specify default-features = false would suddenly stop parsing unicode domains.
Let's remove this for now, and we can try to add it back as a #[cfg(feature = "disable-idna")]. Not sure if the idna crate not being optional still adds to the wasm file size, or if it gets trimmed at link time.

@valenting valenting changed the title remove IDNA feature Make IDNA dependency non-optional Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants