feat(url): Add quirks::internal_components
#788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Aaron O'Mullan <aaron.omullan@gmail.com>
7 tasks
littledivy
changed the title
URL::internal_componentsquirks::internal_components
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 85.23% 85.26% +0.03%
==========================================
Files 22 22
Lines 3894 3903 +9
==========================================
+ Hits 3319 3328 +9
Misses 575 575
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lucacasonato
reviewed
Sep 5, 2022
There was a problem hiding this comment.
This looks good to me functionality wise. Please add a couple of tests.
@valenting do you have concerns exposing this internal structure in a semi-public API? Exposing this info would allow us to significantly speed up our URL JS global in Deno.
|
I would prefer feature-gate this API instead. If that's not possible I can live with it. 🤷♂️ |
lucacasonato
reviewed
Sep 6, 2022
|
LGTM. @lucacasonato approve and merge at your convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #762 with added doc comments