Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(idna): fast-path simple/ascii domains #761

Merged
merged 2 commits into from Sep 6, 2022

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Apr 1, 2022

Complements #760, together they reduce url-parsing benches by ~25-30% (or improve throughput by +33-40%)

Before (main 48fcbe1):

test long  ... bench:         484 ns/iter (+/- 6) = 88 MB/s
test short ... bench:         347 ns/iter (+/- 5) = 72 MB/s

Inter (#760):

test long  ... bench:         413 ns/iter (+/- 4) = 104 MB/s
test short ... bench:         298 ns/iter (+/- 9) = 83 MB/s

After (#760 + this #761)

test long  ... bench:         363 ns/iter (+/- 10) = 118 MB/s
test short ... bench:         247 ns/iter (+/- 12) = 101 MB/s

@codecov-commenter
Copy link

Codecov Report

Merging #761 (f86806a) into master (48fcbe1) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   85.33%   85.34%           
=======================================
  Files          22       22           
  Lines        3894     3903    +9     
=======================================
+ Hits         3323     3331    +8     
- Misses        571      572    +1     
Impacted Files Coverage Δ
idna/src/uts46.rs 94.31% <90.90%> (+0.17%) ⬆️
data-url/tests/wpt.rs 84.41% <0.00%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48fcbe1...f86806a. Read the comment docs.

@crowlKats crowlKats merged commit 6e5df8f into servo:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants