Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting file hosts to None #734

Merged
merged 1 commit into from Sep 7, 2022
Merged

Fix setting file hosts to None #734

merged 1 commit into from Sep 7, 2022

Conversation

andrewbanchich
Copy link
Contributor

Fixes #731 for file URLs.

@andrewbanchich andrewbanchich marked this pull request as draft December 10, 2021 16:43
@andrewbanchich andrewbanchich marked this pull request as ready for review December 10, 2021 16:45
@andrewbanchich andrewbanchich changed the title Fix setting file hosts to None Fix setting file hosts to None Dec 10, 2021
@andrewbanchich
Copy link
Contributor Author

Any thoughts on this @valenting ?

@valenting
Copy link
Collaborator

Hi, Sorry I missed this one.
I think the fix looks good. Could you rebase so we get the CI running?
Thanks!

@andrewbanchich
Copy link
Contributor Author

all set @valenting

valenting
valenting approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@valenting valenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valenting valenting merged commit 868719d into servo:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valenting valenting valenting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_host not working
2 participants
@andrewbanchich @valenting