Remove redundant field names in struct init #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides the obvious minimization, these changes avoid lints of the
following form from clippy:
warning: redundant field names in struct initialization
--> src/form_urlencoded.rs:30:13
|
30 | Parse { input: input }
| ^^^^^^^^^^^^ help: replace it with: `input`
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
This code probably dates from before this syntax existed in the language :) I generally don’t use Clippy and being "clippy-clean" is not at all a goal, but this particular change looks good to me. Thanks. @bors-servo r+ |
|
📌 Commit cce2d32 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 23, 2019
…Sapin
Remove redundant field names in struct init
Besides the obvious minimization, these changes avoid lints of the following form from clippy:
``` txt
warning: redundant field names in struct initialization
--> src/form_urlencoded.rs:30:13
|
30 | Parse { input: input }
| ^^^^^^^^^^^^ help: replace it with: `input`
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
```
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/526)
<!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the obvious minimization, these changes avoid lints of the following form from clippy:
warning: redundant field names in struct initialization --> src/form_urlencoded.rs:30:13 | 30 | Parse { input: input } | ^^^^^^^^^^^^ help: replace it with: `input` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_namesThis change is