Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VALUE_CHARS EncodeSet #134

Merged
merged 2 commits into from Nov 13, 2015
Merged

Added VALUE_CHARS EncodeSet #134

merged 2 commits into from Nov 13, 2015

Conversation

mikedilger
Copy link
Contributor

This character set is based off of rfc5987 section 3.2
https://tools.ietf.org/html/rfc5987#section-3.2
for the ABNF value-chars which is used by certain HTTP
header field values such as Content-Disposition filename*

Not sure about the constant name 'VALUE_CHARS'

Review on Reviewable

This character set is based off of rfc5987 section 3.2
https://tools.ietf.org/html/rfc5987#section-3.2
for the ABNF `value-chars` which is used by certain HTTP
header field values such as Content-Disposition `filename*`
@SimonSapin
Copy link
Member

This is HTTP-specific, right? How about HTTP_VALUE?

To use it from other crates you’ll also want to add an EncodeSet constant in percent_encoding.rs. Please include the URL to the definition in a doc-comment there.

@mikedilger
Copy link
Contributor Author

Ok, I think I've addressed your concerns in this last commit.

@SimonSapin
Copy link
Member

Looks good.

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 00fd5e3 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 00fd5e3 with merge 845e14b...

bors-servo pushed a commit that referenced this pull request Nov 13, 2015
Added VALUE_CHARS EncodeSet

This character set is based off of rfc5987 section 3.2
https://tools.ietf.org/html/rfc5987#section-3.2
for the ABNF `value-chars` which is used by certain HTTP
header field values such as Content-Disposition `filename*`

Not sure about the constant name 'VALUE_CHARS'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - travis

@bors-servo bors-servo merged commit 00fd5e3 into servo:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants