Remove min_const_generics feature
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We will need to wait until rust-lang/rust#79135 is merged and released to the nightly channel before we can merge this PR. |
mbrubeck
reviewed
Dec 27, 2020
src/lib.rs
Outdated
| @@ -1934,34 +1933,13 @@ impl<'a> Drop for SetLenOnDrop<'a> { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "const_generics")] | |||
There was a problem hiding this comment.
I'd like to keep use of const generics behind an optional feature in smallvec 1.x, so it can continue compiling on Rust versions older than 1.51. Let's wait until 2.0 to remove this feature completely.
There was a problem hiding this comment.
Ooopsss... My bad :p
|
@bors-servo r+ |
|
📌 Commit 2964a84 has been approved by |
|
☀️ Test successful - checks-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rust-lang/rust#79135.
If #240 is already under development and will be available before the 1.50 release, then feel free to close this PR. Otherwise, the feature removal will benefit upstream projects in the meanwhile.