Implement into_boxed_slice() and doc-comment it. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ Thanks, looks good! |
|
📌 Commit 8b72dba has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 11, 2019
Implement into_boxed_slice() and doc-comment it. Implements `into_boxed_slice()` as per suggestion in #184. I didn't write tests, since all I did was to call an existing method of `SmallVec`, `into_vec()` to create a `Vec` from it and then call a method of `alloc::vec::Vec`, `into_boxed_slice()` on the resulting `Vec`. Thus, nothing in my code needs testing, since it is trivially offloading to other methods. I didn't, however, find a test exercising `into_vec()`, however. That is maybe something I can do? If so, can I get some pointers to where I should look for example tests and where my tests should live? EDIT: Never mind, I forgot that unit tests are in the same file, so I scrutinized smallvec_ops.rs to search for a test for `into_vec()` and couldn't find it.
|
☀️ Test successful - checks-travis |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Dec 20, 2019
Version 1.1.0 Changes in this release: * Added new method `SmallVec::into_boxed_slice` (#190). * Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182). * `IntoIter` now implements `Clone` (#192). * Improved documentation and testing (#186, #189). * Minor code cleanups (#176). Also added a simple example to the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
into_boxed_slice()as per suggestion in #184.I didn't write tests, since all I did was to call an existing method of
SmallVec,into_vec()to create aVecfrom it and then call a method ofalloc::vec::Vec,into_boxed_slice()on the resultingVec. Thus, nothing in my code needs testing, since it is trivially offloading to other methods.I didn't, however, find a test exercising
into_vec(), however. That is maybe something I can do? If so, can I get some pointers to where I should look for example tests and where my tests should live?EDIT: Never mind, I forgot that unit tests are in the same file, so I scrutinized smallvec_ops.rs to search for a test for
into_vec()and couldn't find it.