Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: new release (miri pass) #177

Closed
CAD97 opened this issue Nov 2, 2019 · 1 comment
Closed

Request: new release (miri pass) #177

CAD97 opened this issue Nov 2, 2019 · 1 comment

Comments

@CAD97
Copy link

CAD97 commented Nov 2, 2019

The latest published version (0.6.12) does not include these commits, which includes #162 which removes mem::uninitialized uses and lets the crate run under miri.

I was trying to run what appears to be a UB-based issue in a rust-analyzer (rowan) patch under miri and ran into this.

You should probably also consider submitting a RustSec advisory for the miri-disapproved mem::uninitialized usage.

Miri evaluation error
error[E0080]: Miri evaluation error: type validation failed: encountered uninitialized bytes at [0].inner.value, but expected a valid enum discriminant
   --> D:\usr\.cargo\registry\src\github.com-1ecc6299db9ec823\smallvec-0.6.12\lib.rs:409:49
    |
409 |                 data: SmallVecData::from_inline(mem::uninitialized()),
    |                                                 ^^^^^^^^^^^^^^^^^^^^ Miri evaluation error: type validation failed: encountered uninitialized bytes at [0].inner.value, but expected a valid enum discriminant

Side note: master still has a toml advertising a version number of 0.6.10.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Nov 2, 2019

I have an open PR #175 for a new release.

@mbrubeck mbrubeck closed this as completed Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants