Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code cleanups #176

Merged
merged 2 commits into from Nov 3, 2019
Merged

Some code cleanups #176

merged 2 commits into from Nov 3, 2019

Conversation

mbrubeck
Copy link
Collaborator

Apply some clippy suggestions, and revert a failed optimization.

as suggested by clippy
This reverts commit 1a8a550.

This didn't actually provide any size optimization benefits, and the
code is slightly simpler without it.
@emilio
Copy link
Member

emilio commented Nov 3, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0e8f5e9 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 0e8f5e9 with merge 0afb664...

bors-servo pushed a commit that referenced this pull request Nov 3, 2019
Some code cleanups

Apply some clippy suggestions, and revert a failed optimization.
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: emilio
Pushing 0afb664 to master...

@bors-servo bors-servo merged commit 0e8f5e9 into servo:master Nov 3, 2019
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Dec 19, 2019
Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (servo#190).
* Added new method `IntoIter::as_slice` (servo#182).
* `IntoIter` now implements `Clone` (servo#192).
* Improved documentation and testing (servo#186, servo#189).
* Minor code cleanups (servo#176).
@mbrubeck mbrubeck mentioned this pull request Dec 19, 2019
bors-servo pushed a commit that referenced this pull request Dec 20, 2019
Version 1.1.0

Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (#190).
* Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182).
* `IntoIter` now implements `Clone` (#192).
* Improved documentation and testing (#186, #189).
* Minor code cleanups (#176).

Also added a simple example to the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants