Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using grow to shrink to inline. #152

Merged
merged 1 commit into from Jun 7, 2019
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 6, 2019

Using grow on a spilled SmallVec to shrink to an unspilled SmallVec would result in a corrupted structure, as capacity was not updated.

Fixes #149


This change is Reviewable

@emilio
Copy link
Member

emilio commented Jun 7, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 50a50ed has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 50a50ed with merge f96322b...

bors-servo pushed a commit that referenced this pull request Jun 7, 2019
Fix using `grow` to shrink to inline.

Using `grow` on a spilled SmallVec to shrink to an unspilled SmallVec would result in a corrupted structure, as `capacity` was not updated.

Fixes #149

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/152)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: emilio
Pushing f96322b to master...

@bors-servo bors-servo merged commit 50a50ed into servo:master Jun 7, 2019
@jdm jdm mentioned this pull request Jun 10, 2019
bors-servo pushed a commit that referenced this pull request Jun 10, 2019
Publish 0.6.10.

This incorporates #144, #152, #150, and #151, which should all be minor version updates according to semver.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/153)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using grow to shrink can cause corruption.
3 participants