Remove dependency on unmaintained 'unreachable' crate #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes servo#128 by inlining the tiny amount of code we use from `unreachable` and its dependency `void`. Eventually this can be replaced with `std::hint::unrechable_unchecked` but this will require bumping our minumum supported Rust version. This will prevent build breakage from users building with broken versions of the `void` crate, as in crossbeam-rs/crossbeam#312.
emilio
approved these changes
Feb 16, 2019
|
@bors-servo r+ |
|
📌 Commit 6510c42 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 16, 2019
Remove dependency on unmaintained 'unreachable' crate Fixes #128 by inlining the tiny amount of code we use from `unreachable` and its dependency `void`. Eventually this can be replaced with `std::hint::unrechable_unchecked` but this will require bumping our minumum supported Rust version. This will prevent build breakage from users building with broken versions of the `void` crate, as in crossbeam-rs/crossbeam#312. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/140) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128 by inlining the tiny amount of code we use from
unreachableand its dependencyvoid. Eventually this can be replaced withstd::hint::unrechable_uncheckedbut this will require bumping our minumum supported Rust version.This will prevent build breakage from users building with broken versions of the
voidcrate, as in crossbeam-rs/crossbeam#312.This change is