fix from_slice possible overallocation #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arthurps found that the code would underreport the vec's capacity if `slice.to_vec()` allocated more than `len` entries. This changes the code to set the correct capacity as reported from the `vec`.
|
@bors-servo r+ |
|
📌 Commit 3400726 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 23, 2018
fix from_slice possible overallocation @arthurps found that the code would underreport the vec's capacity if `slice.to_vec()` allocated more than `len` entries. This changes the code to set the correct capacity as reported from the `vec`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/122) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
cc #118 |
Merged
bors-servo
pushed a commit
that referenced
this pull request
Nov 16, 2018
Version 0.6.6 Changes in this release: * Fix possible over-allocation in `from_slice` (#122) * Optional nightly-only `specialization` feature for `from_slice` optimization (#123) * New `from_raw_parts` constructor (#130) * Documentation and testing improvements (#125, #129) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/131) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arthurps found that the code would underreport the vec's capacity if
slice.to_vec()allocated more thanlenentries. This changes the code to set the correct capacity as reported from thevec.This change is