Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crate does not build due to stdarch_arm_crc32 feature #565

Closed
pbdeuchler opened this issue May 19, 2024 · 0 comments · Fixed by #566
Closed

Crate does not build due to stdarch_arm_crc32 feature #565

pbdeuchler opened this issue May 19, 2024 · 0 comments · Fixed by #566

Comments

@pbdeuchler
Copy link
Contributor

stdarch_arm_crc32 is now stable and use of the feature flag will fail builds:

error[E0635]: unknown feature `stdarch_arm_crc32`
  --> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/pathfinder_simd-0.5.3/src/lib.rs:13:69
   |
13 | #![cfg_attr(all(target_arch = "aarch64", pf_rustc_nightly), feature(stdarch_arm_crc32))]
pbdeuchler added a commit to pbdeuchler/pathfinder that referenced this issue May 19, 2024
@pbdeuchler
Remove stdarch_arm_crc32 feature as it is now stable
bd7270b 
Fixes servo#565
@pbdeuchler pbdeuchler mentioned this issue May 19, 2024
Merged
meadowsys added a commit to meadowsys/pathfinder that referenced this issue Jun 1, 2024
@meadowsys
remove stdarch_arm_crc32 feature attribute
5158a49 
hopefully a temp fix for servo#565?
and also cargo updated its version in cargo.lock lol
github-merge-queue bot pushed a commit that referenced this issue Jun 11, 2024
@pbdeuchler
Remove stdarch_arm_crc32 feature as it is now stable (#566)
4968e81 
Fixes #565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stdarch_arm_crc32 feature as it is now stable pbdeuchler/pathfinder
1 participant
@pbdeuchler