Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeSink requires Tendril<UTF8, NonAtomic>? #430

Open
pwoolcoc opened this issue Jan 4, 2021 · 2 comments
Open

TreeSink requires Tendril<UTF8, NonAtomic>? #430

pwoolcoc opened this issue Jan 4, 2021 · 2 comments

Comments

@pwoolcoc
Copy link

pwoolcoc commented Jan 4, 2021

Is there a reason that we can't implement TreeSink using Atomic Tendrils? I'm trying to use an HTML library built on top of html5ever in a future and it seems that I am unable to because of StrTendril being !Send. I tried swapping out the Tendril used by the tree builder to be Atomic but it seems that once I do that I can no longer implement TreeSink.

@jdm
Copy link
Member

jdm commented Jan 5, 2021

Do you have a code sample that demonstrates what you mean?

@nathaniel-daniel
Copy link

A lot of functions and types used in TreeSink use non-atomic Tendrils, like NodeOrText or the function create_comment. However, I don't think parsing in a future is a good idea since parsing usually takes milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants