Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving h5e/x5e extension story #325

Open
Ygg01 opened this issue Nov 3, 2017 · 0 comments
Open

Improving h5e/x5e extension story #325

Ygg01 opened this issue Nov 3, 2017 · 0 comments

Comments

@Ygg01
Copy link
Contributor

Ygg01 commented Nov 3, 2017

Hi, for issue #323 I was writing a small TokenSink implementation. And to be honest, it took me good half-hour, to hour for that simplistic implementation.

I think what we might need is better docs, and possibly some convenience method. One pain point was adding following part:

     let _ = tok.feed(&mut input);
     tok.end();

Do we need a different tok.feed and tok.end() methods? Can they be let _ = tok.exec(&mut input)?

One thing that also irked me, was that I couldn't have implemented was to have tokenizer abort when encountering anything that isn't Text token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant