Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CGColorSpaceRef be a part of core-graphics-types? #479

Open
kvark opened this issue Nov 22, 2021 · 3 comments
Open

Should CGColorSpaceRef be a part of core-graphics-types? #479

kvark opened this issue Nov 22, 2021 · 3 comments
Labels

Comments

@kvark
Copy link
Member

kvark commented Nov 22, 2021

I wonder if there is a guideline on what goes into the types crate and what doesn't.
In gfx-rs/metal-rs#221, we use CGColorSpaceRef as opaque type, and it would be nice to avoid depending on the whole core-graphics crate there.

@jrmuizel
Copy link
Collaborator

I'd say a decent guideline is that if the type is used by other non-CoreGraphics APIs opaquely it's a good candidate for core-graphics-types.

@jrmuizel
Copy link
Collaborator

Though I guess separating out the CGColorSpace type from the wrapper is a bit of a pain.

@jrmuizel
Copy link
Collaborator

That being said, I have no objection to the whole thing being moved over if it makes life easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants