Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/11596 cloud watch logs data protection #11599

Merged

Conversation

timo92
Copy link
Contributor

@timo92 timo92 commented Dec 12, 2022

Closes: #11596

Note that I was unable to run some tests especially integration-tests locally even after following the steps outlined in https://github.com/serverless/serverless/blob/main/CONTRIBUTING.md#code-style

@medikoo
Copy link
Contributor

medikoo commented Dec 12, 2022

Note that I was unable to run some tests especially integration-tests locally even after following the steps outlined in https://github.com/serverless/serverless/blob/main/CONTRIBUTING.md#code-style

Documentation towards testing can be found at: https://github.com/serverless/serverless/tree/main/test#how-to-run-organize-and-write-tests

@medikoo
Copy link
Contributor

medikoo commented Dec 12, 2022

@timo92 Let us know, once PR is ready

@timo92 timo92 marked this pull request as ready for review December 12, 2022 15:44
@timo92
Copy link
Contributor Author

timo92 commented Dec 12, 2022

Managed to run npm run test successfully (had to delete my AWS_SDK_LOAD_CONFIG env variable).
PR is ready for review @medikoo

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @timo92 that looks very good!

serverless#11596 Convert websockets test use runServerless
@timo92 timo92 requested a review from medikoo December 20, 2022 12:45
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 85.63% // Head: 85.85% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (354f146) compared to base (fcf17a6).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 354f146 differs from pull request most recent head 9f44374. Consider uploading reports for the commit 9f44374 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11599      +/-   ##
==========================================
+ Coverage   85.63%   85.85%   +0.22%     
==========================================
  Files         315      315              
  Lines       13134    13153      +19     
==========================================
+ Hits        11247    11293      +46     
+ Misses       1887     1860      -27     
Impacted Files Coverage Δ
lib/plugins/aws/custom-resources/index.js 98.59% <ø> (ø)
lib/configuration/read.js 82.27% <66.66%> (-1.29%) ⬇️
lib/cli/resolve-configuration-path.js 96.87% <100.00%> (ø)
...ws/package/compile/events/api-gateway/lib/stage.js 100.00% <100.00%> (ø)
lib/plugins/aws/package/compile/events/http-api.js 96.69% <100.00%> (+0.04%) ⬆️
...aws/package/compile/events/websockets/lib/stage.js 100.00% <100.00%> (ø)
lib/plugins/aws/package/lib/merge-iam-templates.js 100.00% <100.00%> (ø)
lib/plugins/aws/provider.js 94.72% <100.00%> (+0.01%) ⬆️
scripts/serverless.js 72.30% <0.00%> (+8.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @timo92 that looks great!

@medikoo medikoo merged commit da7f45a into serverless:main Dec 20, 2022
medikoo pushed a commit that referenced this pull request Dec 20, 2022
@timo92 timo92 deleted the feature/11596-CloudWatch-logs-DataProtection branch December 20, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Aws CloudWatch Logs data protection
2 participants