New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/11596 cloud watch logs data protection #11599
Feature/11596 cloud watch logs data protection #11599
Conversation
Documentation towards testing can be found at: https://github.com/serverless/serverless/tree/main/test#how-to-run-organize-and-write-tests |
@timo92 Let us know, once PR is ready |
Managed to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @timo92 that looks very good!
test/unit/lib/plugins/aws/package/compile/events/websockets/lib/stage.test.js
Outdated
Show resolved
Hide resolved
serverless#11596 Convert websockets test use runServerless
Codecov ReportBase: 85.63% // Head: 85.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11599 +/- ##
==========================================
+ Coverage 85.63% 85.85% +0.22%
==========================================
Files 315 315
Lines 13134 13153 +19
==========================================
+ Hits 11247 11293 +46
+ Misses 1887 1860 -27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @timo92 that looks great!
Closes: #11596
Note that I was unable to run some tests especially integration-tests locally even after following the steps outlined in https://github.com/serverless/serverless/blob/main/CONTRIBUTING.md#code-style