feat: allow serverless configuration with .cjs and .mjs extensions #11586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RianFuro
force-pushed
the
feat/mjs-cjs-configuration
branch
from
99646c9
to
dfd3ee3
Compare
This commit adds support for .cjs and .mjs file extensions on the serverless configuration file. If defined as `serverless.mjs`, the file will be sourced using dynamic import instead of require.js. This encompasses a minimal viable change to allow the user to use es-modules in his codebase. While we don't check the user's package.json for the package type yet, it should still allow using an es-module project by simply setting the configuration extension to .cjs or .mjs explicitly.
RianFuro
force-pushed
the
feat/mjs-cjs-configuration
branch
from
dfd3ee3
to
c6bf53e
Compare
|
Hey @medikoo, just checking, but is there anything else you'd need me to do to accept the PR? |
|
@RianFuro once the update is ready, be sure to re-request review (in top right box) |
medikoo
reviewed
Dec 12, 2022
Codecov ReportBase: 85.63% // Head: 85.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11586 +/- ##
==========================================
- Coverage 85.63% 85.62% -0.01%
==========================================
Files 315 315
Lines 13134 13140 +6
==========================================
+ Hits 11247 11251 +4
- Misses 1887 1889 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
medikoo
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for .cjs and .mjs file extensions on the serverless configuration file. If defined as
serverless.mjs, the file will be sourced using dynamic import instead of require.js.This encompasses a minimal viable change to allow the user to use es-modules in his codebase. While we don't check the user's package.json for the package type yet, it should still allow using an es-module project by simply setting the configuration extension to .cjs or .mjs explicitly.
Addresses: #11039
Relates To: #11147
Notes
I'm following up on the conversation in the related PR and only provide minimal changes that allow serverless to operate in a type: module project without major issues. By recognizing .cjs and .mjs extensions we at least give the user full control on how he wants his configuration to be handled.
I left out auto-detection via the user's
package.jsonmostly because I can't be bothered, the proposed changes are more than enough for me.I read the notes on testing, however I believe it doesn't really apply to these changes? Hence the supplied tests are mostly for completion's sake and for satisfying the coverage checks.
I found a few more references to file-type detection in
lib/cli/triage.js, but I can't really make sense of what's happening there. If any changes are needed here, a few pointers would be appreciated.