New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuration of SnapStart in properties of AWS Lambda Fu… #11576
feat: allow configuration of SnapStart in properties of AWS Lambda Fu… #11576
Conversation
…nction closes issue #11572
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debae great thanks for the update. Can we also have some test that covers this functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debae great thanks for update. We're getting close!
…nction Simplify configuration of SnapStart Make use of runServerless for new testcases closes issue #11572
…nction Make correction in documentation closes issue #11572
@medikoo All comments have been tackled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debae Can you confirm what happens if we first deploy with snapStart: true and then redeploy with this setting removed?
It's really important to confirm on that, to be sure our implementation is solid. Thank you!
@medikoo Sorry, overlooked your question. Below you can find that scenario as well, and removing the property acts the same as putting it to false resulting in SnapStart:None |
Codecov ReportBase: 85.63% // Head: 85.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11576 +/- ##
=======================================
Coverage 85.63% 85.64%
=======================================
Files 314 315 +1
Lines 13133 13148 +15
=======================================
+ Hits 11246 11260 +14
- Misses 1887 1888 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great. Thank you @debae !
Do I have to do anything special to make sure my PublishedVersion is the one being executed? Or it does it with the alias? Say for SQS? |
Adds the possibility to configure the newly added SnapStart property on an AWS Lambda Function.
More info about this can be found : https://docs.aws.amazon.com/lambda/latest/dg/snapstart.html
Closes: #11572