New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11034 extend configuration #11558
11034 extend configuration #11558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklenbw thank you, that looks outstanding! We're on a very good track, please see my comments
Introduces newConfig to remove redundant get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklenbw great thanks for the update!
Reset resolve paths if config was extended
@medikoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklenbw that looks really good! We're getting close. Please see my comments
test/fixtures/programmatic/plugin/extend-config-plugin/index.js
Outdated
Show resolved
Hide resolved
@medikoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mklenbw!
@medikoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklenbw that looks really good.
What we miss is documentation. Can you add a Extending configuration section here: https://github.com/serverless/serverless/tree/main/docs/guides/plugins and document shortly the new feature?
There is already a section named "Extending the configuration". How do you want it to be named? |
@mklenbw that is a good point. Actually, I think we should rename the current "Extending the configuration" section into "Extending the configuration schema", and add new section "Extending and overriding configuration". |
@medikoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklenbw sorry for late review. That looks great! I have just final suggestion for documentation and we should be good
Done. Thanks. Looking forward to use this feature in official version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mklenbw That's outstanding contribution!
Adds a new method in serverless-object for extending the internal configuration. This method extends variablesMeta with the newly added and parsed configuration.
VariablesMeta is now exposed via serverless-object.
Addresses the issue discussed in #11034.
Closes: #11034