Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid JSON parsing error during "ensure-valid-bucket-exists. #11521

Merged
merged 3 commits into from Nov 16, 2022

Conversation

nickgraffis
Copy link
Contributor

Based on #11517 and fully addresses this issue.

Closes: #11517

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 85.66% // Head: 85.63% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e1961e6) compared to base (4169ae1).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11521      +/-   ##
==========================================
- Coverage   85.66%   85.63%   -0.03%     
==========================================
  Files         314      314              
  Lines       13125    13133       +8     
==========================================
+ Hits        11243    11246       +3     
- Misses       1882     1887       +5     
Impacted Files Coverage Δ
...ugins/aws/deploy/lib/ensure-valid-bucket-exists.js 90.74% <50.00%> (-7.14%) ⬇️
lib/plugins/package/package.js 92.00% <0.00%> (-3.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nickgraffis !

@medikoo medikoo merged commit 20d79a2 into serverless:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid JSON parsing error during "ensure-valid-bucket-exists.
2 participants