Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid null error of package #11506

Merged
merged 3 commits into from Nov 15, 2022
Merged

Conversation

shogohida
Copy link
Contributor

Closes: #11491

@shogohida shogohida marked this pull request as ready for review November 8, 2022 13:33
@shogohida shogohida marked this pull request as draft November 8, 2022 13:44
@medikoo medikoo added the bug label Nov 8, 2022
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shogohida thanks for giving that a spin, Note that CI failed

@shogohida
Copy link
Contributor Author

@medikoo
I thought adding ? is a way to avoid an error so I don't know how I should fix test failures (they are based on the change I made in this PR)....

@medikoo
Copy link
Contributor

medikoo commented Nov 14, 2022

@shogohida you've used syntax that's not supported in Node.js v12, which we need to support.

@shogohida shogohida marked this pull request as ready for review November 14, 2022 17:17
@shogohida
Copy link
Contributor Author

@medikoo
Oh, understood. How about this change?

3445cad

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 85.65% // Head: 85.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3445cad) compared to base (a501918).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3445cad differs from pull request most recent head b6ca394. Consider uploading reports for the commit b6ca394 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11506   +/-   ##
=======================================
  Coverage   85.65%   85.66%           
=======================================
  Files         314      314           
  Lines       13120    13125    +5     
=======================================
+ Hits        11238    11243    +5     
  Misses       1882     1882           
Impacted Files Coverage Δ
lib/plugins/package/package.js 95.83% <100.00%> (ø)
...ns/aws/package/compile/events/api-gateway/index.js 100.00% <0.00%> (ø)
lib/plugins/aws/package/compile/events/kafka.js 98.73% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shogohida that looks better. Still CI continues to fail. This time issue is that proposed change doesn't match Prettier formatting

@shogohida
Copy link
Contributor Author

@medikoo
Sorry for not running prettier and lint locally. I fixed the code again by running them so please check the change I made

b6ca394

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shogohida 👍

@medikoo medikoo merged commit c4902f3 into serverless:main Nov 15, 2022
@shogohida shogohida deleted the fix-error-of-layers branch November 15, 2022 15:18
@shogohida
Copy link
Contributor Author

shogohida commented Nov 15, 2022

Thanks for your quick review! Hope to contribute more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants