New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid null error of package #11506
Avoid null error of package #11506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shogohida thanks for giving that a spin, Note that CI failed
@medikoo |
@shogohida you've used syntax that's not supported in Node.js v12, which we need to support. |
Codecov ReportBase: 85.65% // Head: 85.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11506 +/- ##
=======================================
Coverage 85.65% 85.66%
=======================================
Files 314 314
Lines 13120 13125 +5
=======================================
+ Hits 11238 11243 +5
Misses 1882 1882
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shogohida that looks better. Still CI continues to fail. This time issue is that proposed change doesn't match Prettier formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shogohida 👍
Thanks for your quick review! Hope to contribute more! |
Closes: #11491