Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for kinesis event startingPositionTimestamp #11483

Merged

Conversation

overbit
Copy link
Contributor

@overbit overbit commented Oct 28, 2022

Closes: #11148

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 85.79% // Head: 85.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5422225) compared to base (d2b6926).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11483   +/-   ##
=======================================
  Coverage   85.79%   85.79%           
=======================================
  Files         314      314           
  Lines       13259    13264    +5     
=======================================
+ Hits        11375    11380    +5     
  Misses       1884     1884           
Impacted Files Coverage Δ
lib/plugins/aws/package/compile/events/stream.js 98.30% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@overbit overbit changed the title feat: add kinesis starting position timestamp feat: add support for kinesis event startingPositionTimestamp Oct 28, 2022
Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@medikoo medikoo merged commit 5d41995 into serverless:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kinesis - StartingPosition / StartingPostionTimestamp
2 participants