feat: add support for kafka event startingPositionTimestamp #11479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 85.79% // Head: 85.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #11479 +/- ##
==========================================
- Coverage 85.79% 85.66% -0.13%
==========================================
Files 314 314
Lines 13259 13125 -134
==========================================
- Hits 11375 11243 -132
+ Misses 1884 1882 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
2 times, most recently
from
43e3096
to
315796e
Compare
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
315ca5c
to
c6b6b45
Compare
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
c6b6b45
to
cebb796
Compare
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
6529aeb
to
76dbad8
Compare
overbit
changed the title
|
@medikoo shall we change the state from |
medikoo
suggested changes
Nov 2, 2022
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
3b99ca3
to
f7ecb9f
Compare
medikoo
reviewed
Nov 4, 2022
|
|
||
| if ( | ||
| startingPosition === 'AT_TIMESTAMP' && | ||
| !(startingPositionTimestamp !== undefined && startingPositionTimestamp !== null) |
There was a problem hiding this comment.
Let's keep it simple as startingPosition === 'AT_TIMESTAMP' && startingPositionTimestamp == null
| @@ -243,6 +257,10 @@ class AwsCompileKafkaEvents { | |||
| }; | |||
| } | |||
|
|
|||
| if (startingPositionTimestamp !== undefined && startingPositionTimestamp !== null) { | |||
There was a problem hiding this comment.
Same here, let's use simpler condition
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
f7ecb9f
to
3b8b94a
Compare
overbit
force-pushed
the
add-kafka-event-startingPositionTimestamp
branch
from
3b8b94a
to
47654a3
Compare
medikoo
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11478