Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: External integration #11434

Merged
merged 7 commits into from Oct 31, 2022
Merged

Console: External integration #11434

merged 7 commits into from Oct 31, 2022

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Oct 11, 2022

We're switching from tight integration with a Framework service, into AWS account based integration that can serve any AWS applications (not necessarily Serverless Framework based)

@medikoo medikoo self-assigned this Oct 11, 2022
@medikoo medikoo marked this pull request as draft October 11, 2022 14:03
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 85.79% // Head: 85.65% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (34206cc) compared to base (0a49c4f).
Patch coverage: 79.79% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11434      +/-   ##
==========================================
- Coverage   85.79%   85.65%   -0.15%     
==========================================
  Files         314      314              
  Lines       13266    13115     -151     
==========================================
- Hits        11382    11234     -148     
+ Misses       1884     1881       -3     
Impacted Files Coverage Δ
lib/config-schema.js 100.00% <ø> (ø)
lib/plugins/aws/info/index.js 97.22% <ø> (-0.08%) ⬇️
lib/plugins/aws/package/compile/functions.js 94.78% <ø> (-0.41%) ⬇️
lib/plugins/aws/package/index.js 100.00% <ø> (ø)
lib/plugins/aws/package/lib/save-service-state.js 100.00% <ø> (ø)
lib/plugins/aws/package/lib/validate-template.js 100.00% <ø> (ø)
lib/plugins/aws/remove/index.js 100.00% <ø> (ø)
lib/plugins/package/package.js 95.83% <ø> (-0.17%) ⬇️
lib/serverless.js 87.09% <ø> (-0.41%) ⬇️
lib/utils/open-browser.js 69.23% <ø> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@medikoo medikoo force-pushed the 1011-new-console-support branch 12 times, most recently from cf73f98 to bb7444c Compare October 17, 2022 16:45
@medikoo medikoo marked this pull request as ready for review October 20, 2022 16:37
@medikoo medikoo force-pushed the 1011-new-console-support branch 7 times, most recently from e265dbe to 9eb8a7e Compare October 27, 2022 12:09
@medikoo medikoo merged commit 9a41468 into main Oct 31, 2022
@medikoo medikoo deleted the 1011-new-console-support branch October 31, 2022 15:07
@medikoo medikoo restored the 1011-new-console-support branch October 31, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant