possible refactor TODO? Cleaning up relative path require()s in code #11230
pjmattingly
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I was taking a look at the test code and I found quite a few relative path imports for the require()s in that code; For example:
const Serverless = require('../../../../../../../../../../lib/serverless');
This seems brittle and error prone. Is there any interest in revising those require()s to be relative to the root of the project? For example:
const Serverless = require('{root}/lib/serverless');
I'd be happy to take a look at that if there's interest.
Thanks.
Beta Was this translation helpful? Give feedback.
All reactions