Initial support for IAsyncDisposable sinks
#1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skomis-mm
reviewed
Sep 11, 2022
nblumhardt
force-pushed
the
async-disposable
branch
from
7dd60f4
to
13fcaf0
Compare
|
Thank you @skomis-mm 👍 Fixed, and some more test coverage added :-) |
SimonCropp
approved these changes
Sep 12, 2022
Merged
Twinki14
pushed a commit
to Twinki14/CitizenFX.Extensions.Client.Serilog
that referenced
this pull request
Dec 30, 2023
* Support IAsyncDisposable.DisposeAsync() on Logger, and add Log.CloseAndFlushAsync() * Add tests for Log.CloseAndFlushAsync() * Seal DisposeAggregatingSink * Fix tests * Add missing ConfigureAwait(false) * Implement IAsyncDisposable on remaining sink wrapper types * More test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1749
This is admittedly very heavy on
#if. We may be able to do better by polyfillingIAsyncDisposableandValueTaskfor older platforms - keen to explore this, too.Gets some tests and feature flags in place, though, which should be a good start. Eyes appreciated :-)