New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leverage ITuple interface #1733
Conversation
merge conflict resolved |
@@ -396,13 +396,17 @@ public void AllTupleLengthsUpToSevenAreSupportedForCapturing() | |||
Assert.IsType<SequenceValue>(_converter.CreatePropertyValue(t)); | |||
} | |||
|
|||
#if !IVALUETUPLE | |||
|
|||
[Fact] | |||
public void EightPlusValueTupleElementsAreIgnoredByCapturing() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wasnt sure if 8 was a by design choice? or u just didnt want to bloat the conversion code with too many tuple conversions.
if it is by design, let me know and i will make the ITuple respect this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not by design - I think dropping this limitation is good 👍
@nblumhardt thoughts on this on? |
LGTM! |
* leverage ITuple interface * IVALUETUPLE * resolve merge conflict * missed a conflict * const should be ITUPLE
No description provided.