Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullable in MessageTemplateParser #1722

Merged
merged 1 commit into from Aug 9, 2022
Merged

nullable in MessageTemplateParser #1722

merged 1 commit into from Aug 9, 2022

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@@ -161,47 +163,44 @@ static bool TrySplitTagContent(string tagContent, out string propertyNameAndDest
propertyNameAndDestructuring = tagContent;
format = null;
alignment = null;
return true;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did some early returns to simplify the branching logic here. let me know if u prefer it back the previous way

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nblumhardt nblumhardt merged commit 7c59f84 into serilog:dev Aug 9, 2022
@nblumhardt nblumhardt mentioned this pull request Sep 12, 2022
Twinki14 pushed a commit to Twinki14/CitizenFX.Extensions.Client.Serilog that referenced this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants