New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor csproj cleanup #1712
minor csproj cleanup #1712
Conversation
@@ -1,12 +1,8 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<PropertyGroup> | |||
<TargetFrameworks>net6.0;net5.0;netcoreapp3.1;netcoreapp2.1;net452;net46;net48</TargetFrameworks> | |||
<AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile> | |||
<SignAssembly>true</SignAssembly> | |||
<PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> | |||
<Nullable>enable</Nullable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move Nullable
into props file too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we cant yet. since not everything supports it yet
src/Serilog/Serilog.csproj
Outdated
@@ -5,17 +5,12 @@ | |||
<Authors>Serilog Contributors</Authors> | |||
<TargetFrameworks>netstandard2.1;netstandard2.0;netstandard1.3;netstandard1.0;net45;net46;net47;net5.0;net6.0</TargetFrameworks> | |||
<GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
<AssemblyName>Serilog</AssemblyName> | |||
<AssemblyOriginatorKeyFile>../../assets/Serilog.snk</AssemblyOriginatorKeyFile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this line?
* minor csproj cleanup * Remove redundant originator key file property Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>
No description provided.