Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateOnly and TimeOnly support #1702

Merged
merged 6 commits into from Jul 26, 2022
Merged

DateOnly and TimeOnly support #1702

merged 6 commits into from Jul 26, 2022

Conversation

SimonCropp
Copy link
Contributor

No description provided.

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had one minor suggestion

src/Serilog/Capturing/PropertyValueConverter.cs Outdated Show resolved Hide resolved
@nblumhardt nblumhardt merged commit 921037a into serilog:dev Jul 26, 2022
@nblumhardt
Copy link
Member

😎

@SimonCropp
Copy link
Contributor Author

@nblumhardt thanks

@SimonCropp SimonCropp deleted the dateOnlyAndTimeOnly branch July 26, 2022 10:53
@SimonCropp
Copy link
Contributor Author

will seq support properties that are dateonly and time only? like: https://docs.datalust.co/docs/working-with-dates-and-times

@nblumhardt
Copy link
Member

@SimonCropp it'll need some thought 🤔 - thanks for the nudge

@nblumhardt nblumhardt mentioned this pull request Sep 12, 2022
Twinki14 pushed a commit to Twinki14/CitizenFX.Extensions.Client.Serilog that referenced this pull request Dec 30, 2023
* .

* .

* Update global.json

* FEATURE_DATE_AND_TIME_ONLY

* Update PropertyValueConverter.cs

Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants