Remove wrong tag #1699
Merged
Remove wrong tag #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Jul 15, 2022
| @@ -32,7 +32,6 @@ public class PropertyEnricher : ILogEventEnricher | |||
| /// </summary> | |||
| /// <param name="name">The name of the property.</param> | |||
| /// <param name="value">The value of the property.</param> | |||
| /// <returns>A handle to later remove the property from the context.</returns> | |||
| /// <param name="destructureObjects">If true, and the value is a non-primitive, non-array type, | |||
| /// then the value will be converted to a structure; otherwise, unknown types will | |||
| /// be converted to scalars, which are generally stored as strings.</param> | |||
There was a problem hiding this comment.
EnsureValidName throws this exception
There was a problem hiding this comment.
Apologies; L38 in your version, i.e. wondering (without having it in an IDE) whether /// <returns></returns> is necessary before the exception list (there isn't one before the method after, but perhaps it is necessary for a ctor)
|
Thanks @sungam3r, looks good! |
Merged
Twinki14
pushed a commit
to Twinki14/CitizenFX.Extensions.Client.Serilog
that referenced
this pull request
Dec 30, 2023
* Remove wrong tag * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.