Refactor wrapper sinks #1466
Merged
Refactor wrapper sinks #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAggregateSink; remove one level of indirection in DisposeWrappingSink, now renamed DisposeDelegatingSink
…b.com/augustoproiete-forks/serilog--serilog into wrapper-sinks-refactor
|
While I have some time to work through the queue, I'm going to merge a few fairly straightforward things; 👀 always appreciated after-the-fact, this won't be out on stable until we cut a 2.10.0 release :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeAggregateSinkandDisposingSafeAggregateSink- generally we're aiming to avoid inheritance wherever we canLoggerSinkConfiguration.Wrap()to useAggregateSink... #1449 from @augustoproiete -DisposingSafeAggregateSinkshould beDisposingAggregateSink, so that wrapper sinks can observe exceptions in more casesDisposeWrappingSinktoDisposeDelegatingSinkand removes a level of indirection, since the introduction of the disposing aggregate sink means that the enclosed/wrapped sink will always beIDisposablein the case that disposal is required