Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves XML documentation #1429

Merged
merged 9 commits into from
May 5, 2020
Merged

Conversation

rafaelsc
Copy link
Contributor

@rafaelsc rafaelsc commented May 2, 2020

What issue does this PR address?
None

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Changes:

  • Small fixes to some XML Documentation
  • Add exception information XML Documentation
  • Code Format - Better separation of validation and code.
  • Use the same property Name validation code too all code path.

@rafaelsc
Copy link
Contributor Author

rafaelsc commented May 2, 2020

No new unit test is needed.

@rafaelsc
Copy link
Contributor Author

rafaelsc commented May 2, 2020

I have more commits to this PR. I will finish in 2hours.

@rafaelsc
Copy link
Contributor Author

rafaelsc commented May 2, 2020

Done. All changes are commited

@nblumhardt
Copy link
Member

Thanks! Will squash and merge as there are a few commits 👍

@nblumhardt nblumhardt merged commit 5e21647 into serilog:dev May 5, 2020
@rafaelsc rafaelsc deleted the improvements/xmlDocs branch May 6, 2020 22:38
rafaelsc added a commit to rafaelsc/serilog that referenced this pull request May 6, 2020
Improves XML documentation (serilog#1429)
@nblumhardt nblumhardt mentioned this pull request Sep 10, 2020
Twinki14 pushed a commit to Twinki14/CitizenFX.Extensions.Client.Serilog that referenced this pull request Dec 30, 2023
* Add Exception to XML Documentation.
Code Format.
Code Refactor

* Fix XML Documentation

* Update XML Documentation
Code Format

* Fix some legacy invalid XDOC

* Fix some legacy invalid XDOCs

Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants