Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record stringified property as null when ToString() returns null #1427

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

rafaelsc
Copy link
Contributor

What issue does this PR address?
This will fix the issue #1426 - A bad designed Class can cause an Exception when logging with stringification operator.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • [ x ] The commit follows our guidelines
  • [ x ] Unit Tests for the changes have been added (for bug fixes / features)

@nblumhardt nblumhardt changed the title Fix: A bad designed Class can cause an Exception when using Stringify Record stringified property as null when ToString() returns null Apr 30, 2020
@nblumhardt nblumhardt merged commit 645c173 into serilog:dev Apr 30, 2020
nblumhardt added a commit to nblumhardt/serilog that referenced this pull request Jul 26, 2020
… ToString() now renders as an empty string instead of null
@nblumhardt nblumhardt mentioned this pull request Sep 10, 2020
Twinki14 pushed a commit to Twinki14/CitizenFX.Extensions.Client.Serilog that referenced this pull request Dec 30, 2023
… ToString() now renders as an empty string instead of null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants