Improve Serilog.Parsing Unit Tests and Code Coverage - Take 2 #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took me some time to find a test that would test the last 1% in the MessageTemplateParser |
|
Related: #1370 |
|
Thank you @rafaelsc, looks great 👍 Sorry about the slow turnaround, much going on, but these are very worthwhile addition, much appreciated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
This PR is to Improve the Code Coverage for Serilog.Parsing.*
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
I didn't create a PR for this PR. This PR don't fix or add any functionality.
Other information: