Fix custom format string parsing #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix serilog#1353 Custom format string not accepted by the message template parser. Custom numeric format strings may contain plus '+' signs. That character was not recognised by the parser.
|
Thank you, that's great 👍 We might at some point consider any character except for |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
fixes #1353
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
The custom numeric format string mentioned in the bug was not parsed correctly because it contained a plus sign. The IsValidInFormat() function in the MessageTemplateParser did not consider '+' a valid character in format strings.