Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snupkg symbol packages. #1320

Merged
merged 3 commits into from Jun 21, 2019
Merged

Use snupkg symbol packages. #1320

merged 3 commits into from Jun 21, 2019

Conversation

teo-tsirpanis
Copy link
Contributor

What issue does this PR address?

The new recommended way to release debug symbols is separately, via .snupkg packages. This reduces package size, and conforms with NuGet's best practices.

Does this PR introduce a breaking change?

The .snupkg files must be published in NuGet as well.

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:

@nblumhardt
Copy link
Member

This looks great, thanks! 👍

@nblumhardt nblumhardt merged commit c2f78f0 into serilog:dev Jun 21, 2019
@nblumhardt nblumhardt mentioned this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants