Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added link to search of ps courses on readme #1300

Merged
merged 2 commits into from Apr 29, 2019

Conversation

dahlsailrunner
Copy link
Contributor

What issue does this PR address?
None - it adds a link to a list of Pluralsight courses (just uses search tag of "serilog") to the readme file.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)
    (no unit tests added but not applicable)

Other information:
Only a readme update.

@nblumhardt
Copy link
Member

Hi Erik! Thanks for that.

The link won't show me results unless I'm logged into Pluralsight; would https://www.pluralsight.com/search?q=serilog be a better target?

Cheers,
Nick

@dahlsailrunner
Copy link
Contributor Author

Great catch (I seem to be always logged in haha). I've updated and confirmed that it works. I was wondering about updating the banner at the bottom of the page on https://serilog.net/ -- maybe use the same href and say "these great courses"? I didn't see where to contribute that suggestion on the site. Thanks for the great lib community. :)

@nblumhardt
Copy link
Member

Thanks for the reminder about the serilog.net link; I'll zip over and review all the content on that page soon 👍

@nblumhardt nblumhardt merged commit 77e9e28 into serilog:dev Apr 29, 2019
@nblumhardt nblumhardt mentioned this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants