Replace TravisCI with AppVeyor for Linux builds #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we still want to publish the artifacts from the linux build, even if we don't publish them beyond the appveyor tab? If not, is there some way to remove the warning? I'm ok with leaving it as-is too. https://ci.appveyor.com/project/serilog/serilog/builds/23592659/job/rpdjphu4hqmlqqx0#L220 |
|
As a quick sanity check, I verified which tests were running in both builds. In windows builds there are 570 tests passed for In the linux build, there is also 570 tests passed for Only |
|
I think we stay with the Visual Studio build as the source of the packages for the moment. I am not 100% happy with the build.sh setup however I am happy not to do a |
nblumhardt
reviewed
Apr 10, 2019
| for path in src/**/*.csproj; do | ||
| dotnet build -f netstandard1.0 -c Release ${path} | ||
| dotnet build -f netstandard1.3 -c Release ${path} | ||
| done | ||
|
|
||
| echo "🤖 Running tests..." |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: