Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nuget package license format to new format #1266

Merged
merged 2 commits into from May 29, 2019

Conversation

tsimbalar
Copy link
Member

What issue does this PR address?
#1265

`licenseUrl` is now deprecated, so we use `license expression` instead
@tsimbalar
Copy link
Member Author

For some reason, the Nuget package generated by https://ci.appveyor.com/project/serilog/serilog/builds/21388982/artifacts does not seem to have the proper licensing information

image

Not sure what to think of this ... it worked fine with Serilog.Sinks.Console and Serilog.Settings.Configuration.

@nblumhardt
Copy link
Member

🤔

This repository does include a global.json file that pins the tooling to 2.1, while Console and Configuration don't - perhaps shifting the tooling version forward will do the job?

@nblumhardt
Copy link
Member

Any thoughts on what we should do with this one, @tsimbalar ?

@tsimbalar
Copy link
Member Author

Thanks for the nudge !

Sorry, I haven't been able to do much Serlog work lately 😑.

I'll try to get to it eventually, but if somebody has the time to look into it, go for it !

@nblumhardt
Copy link
Member

@tsimbalar I'm only just getting some time put aside again, too. Looking forward to digging into some more substantial Serilog features in the next little while, if the calendar stays sane (fingers crossed :-))

I'll take a look if no one else beats me to it.

@nblumhardt
Copy link
Member

Works now that #1315 has updated the build-time SDK 🎉

@nblumhardt nblumhardt merged commit 36c39eb into serilog:dev May 29, 2019
@nblumhardt nblumhardt mentioned this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants